Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zone of controlplane config #64

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Remove zone of controlplane config #64

merged 1 commit into from
Apr 16, 2020

Conversation

jia-jerry
Copy link
Contributor

@jia-jerry jia-jerry commented Apr 6, 2020 •
edited
Loading

What this PR does / why we need it:

  1. Remove zone field in shoot controlPlaneConfig section
  2. Change Cloud controller configmap used by CCM to secret
    Which issue(s) this PR fixes:
    Fixes Remove zone field in shoot controlPlaneConfig section #63

Special notes for your reviewer:

Release note:

Zone filed of controlPlaneConfig is removed from Shoot.

Now user does not need to maintain Zone filed of controlPlaneConfig in Shoot resource. And also, controlPlaneConfig is not needed.

@jia-jerry jia-jerry requested review from a team as code owners April 6, 2020 13:33
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 6, 2020
rfranzke
rfranzke reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. minor suggestions

pkg/controller/controlplane/clean_old_resources.go Show resolved Hide resolved
pkg/controller/controlplane/clean_old_resources.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2020
@rfranzke
Copy link
Member

rfranzke commented Apr 8, 2020

@jia-jerry kindly rebase

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@rfranzke rfranzke mentioned this pull request Apr 14, 2020
Closed
EmoinLanyu
EmoinLanyu approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@EmoinLanyu EmoinLanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jia-jerry jia-jerry merged commit f80c5a7 into gardener:master Apr 16, 2020
@jia-jerry jia-jerry deleted the remove-zone branch April 16, 2020 10:14
@ialidzhikov ialidzhikov mentioned this pull request Nov 30, 2020
Merged
This was referenced May 4, 2021
Closed
Merged
@petersutter petersutter mentioned this pull request May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@EmoinLanyu EmoinLanyu EmoinLanyu approved these changes

Assignees

@minchaow minchaow

@EmoinLanyu EmoinLanyu

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove zone field in shoot controlPlaneConfig section
7 participants
@jia-jerry @rfranzke @EmoinLanyu @gardener-robot-ci-1 @minchaow @gardener-robot-ci-2 @gardener-robot-ci-3